Skip to content

Conversation

Thegaram
Copy link
Contributor

@Thegaram Thegaram commented Jan 12, 2023

Related l2geth PR: scroll-tech/go-ethereum#187

@Thegaram Thegaram requested a review from zimpha January 12, 2023 10:15
@Thegaram Thegaram marked this pull request as ready for review January 12, 2023 13:05
zimpha
zimpha previously approved these changes Jan 12, 2023
@0xmountaintop 0xmountaintop requested a review from iczc January 12, 2023 14:08
iczc
iczc previously approved these changes Jan 15, 2023
Copy link
Contributor

@iczc iczc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, btw do we need to have the ability to change RECIPIENT?

@Thegaram Thegaram requested a review from maxwolff January 19, 2023 19:21
@ChuhanJin
Copy link
Contributor

46% (0.0%) vs master 46%

@Thegaram Thegaram dismissed stale reviews from iczc and zimpha via 959127c February 10, 2023 13:35
@ChuhanJin
Copy link
Contributor

47% (0.0%) vs master 47%

zimpha
zimpha previously approved these changes Feb 10, 2023
@ChuhanJin
Copy link
Contributor

47% (0.0%) vs master 47%

@Thegaram
Copy link
Contributor Author

LTGM, btw do we need to have the ability to change RECIPIENT?

The L1 recipient can be an upgradable contract. But ideally, on mainnet, these should all be fixed and immutable.

@ChuhanJin
Copy link
Contributor

47% (0.0%) vs master 47%

@Thegaram Thegaram merged commit eb3f187 into staging Feb 11, 2023
@Thegaram Thegaram deleted the add-fee-vault-contract branch February 11, 2023 20:24
ChuhanJin pushed a commit that referenced this pull request Mar 15, 2023
# This is the 1st commit message:

feat: add monitor metrics (#262)

Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
# This is the commit message #2:

refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274)

Co-authored-by: vincent <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #3:

fix: add gas multiplier (#275)


# This is the commit message #4:

feat(libzkp): use dylib instead of staticlib  (#266)

Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: colin <[email protected]>
Co-authored-by: colinlyguo <[email protected]>
# This is the commit message #5:

Revert "fix: add gas multiplier (#275)" (#279)


# This is the commit message #6:

build: add nightly-2022-12-10 rust-related builder image (#282)


# This is the commit message #7:

fix(bridge): compatible with DynamicFeeTxType not supported chain (#280)

Co-authored-by: colinlyguo <[email protected]>
# This is the commit message #8:

feat(contract): enable whitelist relayer (#272)

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #9:

perf(bridge): execute relayer loops independently (#258)

Co-authored-by: colin <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #10:

feat(bridge): confirm block based on "safe" and "finalized" tags (#265)


# This is the commit message #11:

feat: allow to override L2 deployment when address is provided (#293)


# This is the commit message #12:

feat(contracts): Add fee vault (#223)


# This is the commit message #13:

feat(confirmations): Upgrade confirm (#291)


# This is the commit message #14:

feat(coordinator): Enable set ws compression level. (#292)


# This is the commit message #15:

feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281)

Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: xinran chen <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
# This is the commit message #16:

build: update version to `alpha-v1.0` (#301)


# This is the commit message #17:

feat: import genesis batch during startup (#299)

Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #18:

feat(contracts): new bridge contracts (#288)

Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Thegaram <[email protected]>
Co-authored-by: colin <[email protected]>
# This is the commit message #19:

chore: upgrade l2geth dependency for trace type (#304)
ChuhanJin pushed a commit that referenced this pull request Mar 15, 2023
Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274)

Co-authored-by: vincent <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

fix: add gas multiplier (#275)

feat(libzkp): use dylib instead of staticlib  (#266)

Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: colin <[email protected]>
Co-authored-by: colinlyguo <[email protected]>

Revert "fix: add gas multiplier (#275)" (#279)

build: add nightly-2022-12-10 rust-related builder image (#282)

fix(bridge): compatible with DynamicFeeTxType not supported chain (#280)

Co-authored-by: colinlyguo <[email protected]>

feat(contract): enable whitelist relayer (#272)

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

perf(bridge): execute relayer loops independently (#258)

Co-authored-by: colin <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

feat(bridge): confirm block based on "safe" and "finalized" tags (#265)

feat: allow to override L2 deployment when address is provided (#293)

feat(contracts): Add fee vault (#223)

feat(confirmations): Upgrade confirm (#291)

feat(coordinator): Enable set ws compression level. (#292)

feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281)

Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: xinran chen <[email protected]>
Co-authored-by: Ubuntu <[email protected]>

build: update version to `alpha-v1.0` (#301)

feat: import genesis batch during startup (#299)

Co-authored-by: HAOYUatHZ <[email protected]>

feat(contracts): new bridge contracts (#288)

Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Thegaram <[email protected]>
Co-authored-by: colin <[email protected]>

chore: upgrade l2geth dependency for trace type (#304)

feat(bridge): update the watcher and relayer based on the new contract (#305)

Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: zimpha <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

fix incorrect block order during batch recovery (#311)

fix(bridge): fix batch proposer (#312)

Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

fix: Flush buffered writer (#314)

fix(config): fix typos (#315)

feat(bridge): only update gas price oracle for exceeding diff threshold (#319)

fix(bridge): fix typos (#321)

feat(batch proposer): add time limit to commit batches (#323)

fix(db): fix `SetMaxOpenConns` (#328)

Fix(zkevm): fix zkevm bug for goerli.  (#334)

fix(build): jenkinsfile tag job optimized and fix (#331)

Co-authored-by: vincent <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

fix: reduce finalize batch tx frequency (#332)

alpha inegration with multibin

fix makefile

fix lint

fix lint

try fix commit

op

fix lint

goimports

trigger ci

bugfix(libzkp): fix difficulty (#343)

fix(contract): forbid to call message queue and l2 messenger from l1 (#341)

Co-authored-by: HAOYUatHZ <[email protected]>

fix(roller): fix stack bug (#320)

Co-authored-by: HAOYUatHZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants