Skip to content

merge #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10,000 commits into from
Jun 12, 2019
Merged

merge #1

merged 10,000 commits into from
Jun 12, 2019

Conversation

amjadm61
Copy link
Owner

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

serhii-balko and others added 30 commits May 31, 2019 09:33
…evelop

* '2.3-develop' of github.com:sweikenb/magento2:
  Update Generator.php
  Update Generator.php
  Update Generator.php
  Update Generator.php
…waggerUI #23025

 - Merge Pull Request #23025 from sweikenb/magento2:2.3-develop
 - Merged commits:
   1. a50d629
   2. 64e32d7
   3. b6867e1
   4. e9a6475
   5. 19ea6d7
   6. b0ea952
   7. 9c33b68
fix incorrect translation for mobile navigation items with "All" prefix
…op expedited

Accepted Community Pull Requests:
 - #23035: [Validator] Fix wrong behaviour of validation scroll (by @Den4ik)
 - #23033: Issue fix #23030: Swatch change Image does not slide to first Image (by @milindsingh)
 - #23020: Remove direct use of object manager (by @AnshuMishra17)
 - #22920: Mview Indexers getList should return integer values of id's and not strings (by @mhodge13)


Fixed GitHub Issues:
 - #23034: Wrong behaviour of validation scroll (reported by @Den4ik) has been fixed in #23035 by @Den4ik in 2.3-develop branch
   Related commits:
     1. 5b01913

 - #23030: Magento2 Swatch change Image does not slide to first Image (reported by @matin73) has been fixed in #23033 by @milindsingh in 2.3-develop branch
   Related commits:
     1. 2770945
- Skipping unstable tests
- Fixing tests that clear schedule update filters but don't wait properly
sidolov and others added 29 commits June 6, 2019 22:21
…of status #23118

 - Merge Pull Request #23118 from Wirson/magento2:23053-sendfriend-visibility-fix
 - Merged commits:
   1. 265e0d4
   2. 74373a0
- Add wait before proceed to checkout to MTF test;
…andles recreates images correctly when pub/media/catalog is cleared. #21605
…op expedited

Accepted Community Pull Requests:
 - #22341: Apply coupoun and scroll top to check. applied successfully or not (by @krnshah)
 - #23025: Re-enable XML as request and response types within the SwaggerUI (by @sweikenb)
 - #22646: Fixed Issue #22087 (by @Surabhi-Cedcoss)
 - #21131: Fix Issue #19872 - checking if image is in media directory (by @Bartlomiejsz)


Fixed GitHub Issues:
 - #22087: Products Ordered Report - Not grouped by product (reported by @nicholasscottfish) has been fixed in #22646 by @Surabhi-Cedcoss in 2.3-develop branch
   Related commits:
     1. b8bc288
     2. 82d09dc

 - #19872: Magento 2.3 category edit page "Select from gallery" button not working. (reported by @aasim110) has been fixed in #21131 by @Bartlomiejsz in 2.3-develop branch
   Related commits:
     1. ed43407
     2. 619475d
     3. 17ed8d4
     4. ae61b70
     5. 112476a
     6. 8522a14
     7. 07a296a
     8. a142ef2
     9. de8df60
     10. d06fb10

 - #22092: Assigning Catalog Image from Gallery, then Saving Twice, Clears Image (reported by @jasonkcarter) has been fixed in #21131 by @Bartlomiejsz in 2.3-develop branch
   Related commits:
     1. ed43407
     2. 619475d
     3. 17ed8d4
     4. ae61b70
     5. 112476a
     6. 8522a14
     7. 07a296a
     8. a142ef2
     9. de8df60
     10. d06fb10
Accepted Community Pull Requests:
 - #23118: #23053 : sendfriend verifies product visibility instead of status (by @Wirson)
 - #21605: [2.3] Database Media Storage - Admin Product Edit Page handles recreates images correctly when pub/media/catalog is cleared. (by @gwharton)
 - #23007: [Fixed] Reset feature does not clear the date (by @niravkrish)
 - #21876: $product->getUrlInStore() does not allow to override the scope in backend context (by @Nazar65)
 - #20848: Partial docs fixes in Newsletter module (by @SikailoISM)


Fixed GitHub Issues:
 - #23053: Sendfriend works for products with visibility not visible individually (reported by @TomashKhamlai) has been fixed in #23118 by @Wirson in 2.3-develop branch
   Related commits:
     1. 265e0d4
     2. 74373a0

 - #21546: [2.3] Database Media Storage - New Product Images fail to be processed correctly (reported by @gwharton) has been fixed in #21605 by @gwharton in 2.3-develop branch
   Related commits:
     1. 5f6e24f

 - #21604: Database Media Storage - Admin Product Edit page does not handle product images correctly in database storage mode (reported by @gwharton) has been fixed in #21605 by @gwharton in 2.3-develop branch
   Related commits:
     1. 5f6e24f

 - #22940: Reset feature does not clear the date (reported by @renard123) has been fixed in #23007 by @niravkrish in 2.3-develop branch
   Related commits:
     1. c9f98fc
     2. 40cc415

 - #4247: getProductUrl does not allow to override the scope in backend context (reported by @fetzi) has been fixed in #21876 by @Nazar65 in 2.3-develop branch
   Related commits:
     1. c50975a
[Magento Community Engineering] Community Contributions - 2.3-develop
@amjadm61 amjadm61 merged commit 878ea22 into amjadm61:2.3-develop Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.