.gitattributes

@@ -1,7 +1,2 @@
 # text files must be lf for golden file tests to work
-*.txt eol=lf
-*.json eol=lf
-*.py eol=lf
-*.yml eol=lf
-*.yaml eol=lf
-*.md eol=lf
+* text=auto eol=lf

.github/workflows/ci.yml

@@ -10,14 +10,20 @@ on:
       - main
       - release-*
 
+concurrency:
+  # For pull requests, cancel all currently-running jobs for this workflow
+  # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
 jobs:
   infra:
     name: Lint
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: "3.10"
     - name: Install dependencies & browsers
@@ -28,7 +34,7 @@ jobs:
         python setup.py bdist_wheel
         python -m playwright install --with-deps
     - name: Lint
-      uses: pre-commit/action@v2.0.3
+      run: pre-commit run --show-diff-on-failure --color=always --all-files
     - name: Generate APIs
       run: bash scripts/update_api.sh
     - name: Verify generated API is up to date
@@ -77,11 +83,23 @@ jobs:
         - os: macos-11.0
           python-version: '3.10'
           browser: chromium
+        - os: windows-latest
+          python-version: '3.11'
+          browser: chromium
+        - os: macos-latest
+          python-version: '3.11'
+          browser: chromium
+        - os: ubuntu-latest
+          python-version: '3.11'
+          browser: chromium
+        - os: windows-latest
+          python-version: '3.11'
+          browser: chromium
     runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install dependencies & browsers
@@ -90,7 +108,7 @@ jobs:
         pip install -r local-requirements.txt
         pip install -e .
         python setup.py bdist_wheel
-        python -m playwright install --with-deps
+        python -m playwright install --with-deps ${{ matrix.browser }}
     - name: Common Tests
       run: pytest tests/common --browser=${{ matrix.browser }} --timeout 90
     - name: Test Reference count
@@ -111,7 +129,7 @@ jobs:
     - name: Test Async API
       if: matrix.os == 'ubuntu-latest'
       run: xvfb-run pytest tests/async --browser=${{ matrix.browser }} --timeout 90
-    - uses: actions/upload-artifact@v2
+    - uses: actions/upload-artifact@v3
       if: failure()
       with:
         name: ${{ matrix.browser }}-${{ matrix.os }}-${{ matrix.python-version }}
@@ -135,9 +153,9 @@ jobs:
           browser-channel: msedge
     runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: "3.10"
     - name: Install dependencies & browsers
@@ -161,7 +179,7 @@ jobs:
     - name: Test Async API
       if: matrix.os == 'ubuntu-latest'
       run: xvfb-run pytest tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
-    - uses: actions/upload-artifact@v2
+    - uses: actions/upload-artifact@v3
       if: failure()
       with:
         name: ${{ matrix.browser-channel }}-${{ matrix.os }}
@@ -172,10 +190,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-20.04, macos-10.15, windows-2019]
+        os: [ubuntu-20.04, macos-11, windows-2019]
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - name: Get conda
@@ -187,3 +205,22 @@ jobs:
         run: conda install conda-build conda-verify
       - name: Build
         run: conda build .
+
+  test_examples:
+    name: Examples
+    runs-on: ubuntu-22.04
+    defaults:
+      run:
+        working-directory: examples/todomvc/
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Python
+      uses: actions/setup-python@v4
+      with:
+        python-version: '3.10'
+    - name: Install dependencies & browsers
+      run: |
+        pip install -r requirements.txt
+        python -m playwright install --with-deps chromium
+    - name: Common Tests
+      run: pytest

.github/workflows/publish.yml

@@ -6,9 +6,9 @@ jobs:
   deploy-pypi:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: 3.9
     - name: Install dependencies
@@ -30,7 +30,7 @@ jobs:
         os: [ubuntu-latest, windows-latest, macos-latest]
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - name: Get conda

.github/workflows/publish_canary_docker.yml

@@ -11,9 +11,9 @@ jobs:
     runs-on: ubuntu-20.04
     if: github.repository == 'microsoft/playwright-python'
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: "3.10"
     - name: Install dependencies & browsers
@@ -27,7 +27,7 @@ jobs:
         username: playwright
         password: ${{ secrets.DOCKER_PASSWORD }}
     - name: Set up Docker QEMU for arm64 docker builds
-      uses: docker/setup-qemu-action@v1
+      uses: docker/setup-qemu-action@v2
       with:
         platforms: arm64
     - name: publish docker canary

.github/workflows/publish_release_docker.yml

@@ -17,9 +17,9 @@ jobs:
     runs-on: ubuntu-20.04
     if: github.repository == 'microsoft/playwright-python'
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: "3.10"
     - uses: azure/docker-login@v1
@@ -28,7 +28,7 @@ jobs:
         username: playwright
         password: ${{ secrets.DOCKER_PASSWORD }}
     - name: Set up Docker QEMU for arm64 docker builds
-      uses: docker/setup-qemu-action@v1
+      uses: docker/setup-qemu-action@v2
       with:
         platforms: arm64
     - name: Install dependencies & browsers

.github/workflows/test_docker.yml

@@ -18,12 +18,18 @@ on:
       - release-*
 jobs:
   build:
-    timeout-minutes: 60
-    runs-on: ubuntu-20.04
+    timeout-minutes: 120
+    runs-on: ubuntu-22.04
+    strategy:
+      fail-fast: false
+      matrix:
+        docker-image-variant:
+          - focal
+          - jammy
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: "3.10"
     - name: Install dependencies
@@ -32,10 +38,10 @@ jobs:
         pip install -r local-requirements.txt
         pip install -e .
     - name: Build Docker image
-      run: bash utils/docker/build.sh --amd64 focal playwright-python:localbuild-focal
+      run: bash utils/docker/build.sh --amd64 ${{ matrix.docker-image-variant }} playwright-python:localbuild-${{ matrix.docker-image-variant }}
     - name: Test
       run: |
-        CONTAINER_ID="$(docker run --rm -v $(pwd):/root/playwright --name playwright-docker-test --workdir /root/playwright/ -d -t playwright-python:localbuild-focal /bin/bash)"
+        CONTAINER_ID="$(docker run --rm -v $(pwd):/root/playwright --name playwright-docker-test --workdir /root/playwright/ -d -t playwright-python:localbuild-${{ matrix.docker-image-variant }} /bin/bash)"
         # Fix permissions for Git inside the container
         docker exec "${CONTAINER_ID}" chown -R root:root /root/playwright
         docker exec "${CONTAINER_ID}" pip install -r local-requirements.txt

.github/workflows/trigger_internal_tests.yml

@@ -0,0 +1,21 @@
+name: "Internal Tests"
+
+on:
+  push:
+    branches:
+      - main
+      - release-*
+
+jobs:
+  trigger:
+    name: "trigger"
+    runs-on: ubuntu-20.04
+    steps:
+    - run: |
+        curl -X POST \
+          -H "Accept: application/vnd.github.v3+json" \
+          -H "Authorization: token ${GH_TOKEN}" \
+          --data "{\"event_type\": \"playwright_tests_python\", \"client_payload\": {\"ref\": \"${GITHUB_SHA}\"}}" \
+          https://github.com/api/repos/microsoft/playwright-browsers/dispatches
+      env:
+        GH_TOKEN: ${{ secrets.REPOSITORY_DISPATCH_PERSONAL_ACCESS_TOKEN }}

.pre-commit-config.yaml

@@ -2,10 +2,11 @@
 # See https://pre-commit.com/hooks.html for more hooks
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.1.0
+    rev: v4.3.0
     hooks:
       - id: trailing-whitespace
       - id: end-of-file-fixer
+        exclude: tests/assets/har-sha1-main-response.txt
       - id: check-yaml
       - id: check-toml
       - id: requirements-txt-fixer
@@ -14,16 +15,16 @@ repos:
       - id: check-executables-have-shebangs
       - id: check-merge-conflict
   - repo: https://github.com/psf/black
-    rev: 22.3.0
+    rev: 22.10.0
     hooks:
       - id: black
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.942
+    rev: v0.982
     hooks:
       - id: mypy
-        additional_dependencies: [types-pyOpenSSL==21.0.3]
+        additional_dependencies: [types-pyOpenSSL==22.1.0.1]
   - repo: https://github.com/pycqa/flake8
-    rev: 4.0.1
+    rev: 5.0.4
     hooks:
       - id: flake8
   - repo: https://github.com/pycqa/isort
@@ -38,4 +39,4 @@ repos:
         language: node
         pass_filenames: false
         types: [python]
-        additional_dependencies: ["pyright@1.1.210"]
+        additional_dependencies: ["pyright@1.1.278"]

README.md

@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->102.0.5005.40<!-- GEN:stop --> | ✅ | ✅ | ✅ |
-| WebKit <!-- GEN:webkit-version -->15.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
-| Firefox <!-- GEN:firefox-version -->99.0.1<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Chromium <!-- GEN:chromium-version -->110.0.5481.38<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| WebKit <!-- GEN:webkit-version -->16.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Firefox <!-- GEN:firefox-version -->108.0.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 
 ## Documentation
 

conda_build_config.yaml

@@ -3,3 +3,4 @@ python:
   - 3.8
   - 3.9
   - "3.10"
+  - "3.11"

examples/todomvc/mvctests/test_clear_completed_button.py

@@ -0,0 +1,38 @@
+from typing import Generator
+
+import pytest
+
+from playwright.sync_api import Page, expect
+
+from .utils import TODO_ITEMS, create_default_todos
+
+
+@pytest.fixture(autouse=True)
+def run_around_tests(page: Page) -> Generator[None, None, None]:
+    # setup before a test
+    page.goto("https://demo.playwright.dev/todomvc")
+    create_default_todos(page)
+    # run the actual test
+    yield
+    # run any cleanup code
+
+
+def test_should_display_the_correct_text(page: Page) -> None:
+    page.locator(".todo-list li .toggle").first.check()
+    expect(page.locator(".clear-completed")).to_have_text("Clear completed")
+
+
+def test_should_clear_completed_items_when_clicked(page: Page) -> None:
+    todo_items = page.locator(".todo-list li")
+    todo_items.nth(1).locator(".toggle").check()
+    page.locator(".clear-completed").click()
+    expect(todo_items).to_have_count(2)
+    expect(todo_items).to_have_text([TODO_ITEMS[0], TODO_ITEMS[2]])
+
+
+def test_should_be_hidden_when_there_are_no_items_that_are_completed(
+    page: Page,
+) -> None:
+    page.locator(".todo-list li .toggle").first.check()
+    page.locator(".clear-completed").click()
+    expect(page.locator(".clear-completed")).to_be_hidden()

examples/todomvc/mvctests/test_counter.py

@@ -0,0 +1,28 @@
+from typing import Generator
+
+import pytest
+
+from playwright.sync_api import Page, expect
+
+from .utils import TODO_ITEMS, assert_number_of_todos_in_local_storage
+
+
+@pytest.fixture(autouse=True)
+def run_around_tests(page: Page) -> Generator[None, None, None]:
+    # setup before a test
+    page.goto("https://demo.playwright.dev/todomvc")
+    # run the actual test
+    yield
+    # run any cleanup code
+
+
+def test_should_display_the_current_number_of_todo_items(page: Page) -> None:
+    page.locator(".new-todo").fill(TODO_ITEMS[0])
+    page.locator(".new-todo").press("Enter")
+    expect(page.locator(".todo-count")).to_contain_text("1")
+
+    page.locator(".new-todo").fill(TODO_ITEMS[1])
+    page.locator(".new-todo").press("Enter")
+    expect(page.locator(".todo-count")).to_contain_text("2")
+
+    assert_number_of_todos_in_local_storage(page, 2)