[pull] master from aws:master #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Adds Code Coverage * Adds code to create coverage report * Adds option to upload report to codecov.io * Use requests
* Shadow LTS initial commit: - added shadow library src folder - added utest for shadow to test shadow library APIs and MACROS Co-authored-by: DanielYEHsieh <[email protected]> Co-authored-by: Hsieh <[email protected]>
* Remove C99 %hhu format specifier * Add unsigned long to %lu format specifiers * Log stringified status codes instead of integers
* Return suback when server refuses subscription * Add new deserialized struct parameter to callback * Continue process loop if server refused
* Log stripped out filename as metadata instead of function name for ISO C adherence * Make ERROR_LOG as default logging verbosity for MQTT unit tests
… initialization of SSL object (#1100) Fix 2 different corner cases of SegFault in demos: 1) Using incorrect hostname for which DNS resolution fails 2) Running the demo against an MQTT server that is down (thereby, not accepting TCP connections)
* Create harness for httpParserOnMessageBeginCallback * Try a different approach * Add CBMC proofs for all callbacks (still need to resolve same object violation issue) * Change pLoc to be within bounds of response buffer * Push callback stubs * Update to fix memcpy src/dst overlap error * Update all CBMC proofs to use mangled names of static method under test (Problem with httpParserOnHeadersCompleteCallback) * Update httpParserOnHeadersCompleteCallback harness with right assumptions but assumptions not propagating * Update httpParserOnHeadersCompleteCallback to run correctly using an imperative approach * Update httpParserOnBodyCallback to use memmove and stub it out for the proof * Add stub for memmove * Document additional functions for http cbmc state * Update transport interface send stubs to remove execution paths that are never reached * Add full coverage for findHeaderInResponse * Update http_parser_execute field and value to point to buffer param * Complete headerFieldParserCallback proof * Update lexicon.txt for http * Add dest to http lexicon.txt * Add docstrings to allocators for HTTPClient_ReadHeader * Commit remaining proofs for http parser callbacks * Add missing newlines to files * Revert Makefile.common to original * Update cbmc templates to latest commit * Remove unnecessary enclosing parenthesis around UINT64_MAX * Address PR comments * Add missing newlines * Change offsets to be < rather than <= * Address PR comments * Remove unused vars
…egration test SegFault (#1106) * Update SSL transport implementation to avoid SegFault issues * Updates to error messages based on review feedback * Refactor logging logic for OpenSSL_Recv function to be consistent with OpenSSL_Send * Hygiene update in OpenSSL_Recv and OpenSSL_Send functions to NULL check network context parameter * Hygiene change in OpenSSL_Recv for better readability
* Add doxygen comments to structs and enums in mqtt.h * Remove unused publish count parameters in MQTTContext_t
The MQTT metrics report to AWS IoT the SDK/OS version, SDK/OS version and the Hardware Platform. This allows AWS IoT to improve security and provide better technical support.
* Add new API in lightweight MQTT for extracting payload from SUBACK packet * Add parameter names of new API to lexicon.txt * Minor updates * Update readSubackStatus in lightweight file to use named constants * Address hygiene comments from review * Move new API for SUBACK decoding from lightweight to managed layer * Make minor changes suggested in review comments Co-authored-by: Muneeb Ahmed <[email protected]> * Rename API for customer usability and update doc * Remove new QoS and SUBACK failure macros from lightweight API; Add a new enum for SUBACK status in managed API * Fix CI build issues * Adding another word to lexicon.txt for spell check * Address MISRA violation of type promotion in subtraction logic Co-authored-by: Muneeb Ahmed <[email protected]> Co-authored-by: Muneeb Ahmed <[email protected]>
…overridden (#1124) * Add #ifndefs around config macros in demos to allow them to be overridden * Add #error statements for BROKER_ENDPOINT in demo source files
* Add macro to initialize ping response timeout * Remove pingRespTimeoutMs field from MQTT context * Add macro to demo configs * Remove unused MQTT_MAX_QUEUED_PUBLISH_MESSAGES macro
…1116) * Remove extra wrapping parenthesis * Add remaining coverage for HTTPClient_Send and its private methods * Add remaining coverage for HTTPClient_AddRangeHeader
…factor (#1120) * Update proof templates, add proof flag --pointer-primitive-check * Fix overflow in MQTT_SerializeSubscribe, MQTT_SerializeUnsubscribe, MQTT_SerializePublish, and MQTT_SerializePublishHeader. Co-authored-by: Mark R. Tuttle <[email protected]>
…loading (#1126) * Add option to turn off downloading of certificates and create demos/certificates directory * Remove Mosquitto certificate from list of certs to download * Address PR comments * Add CMake command line options to use for configuring demos * Update README.md to contain extra flag for ROOT_CA_CERT_PATH * Set prefix to PWD if any path flags are relative
* Add code examples for mqtt.h
…e paths (#1129) * Utilize IS_ABSOLUTE CMake function instead of REGEX match * Address PR comments
* Upgrade MQTT integration test to use mutual auth, and update its build setup to use CMake cache variables for credentials * Fix build warning from logging * Remove references to test.mosquitto.org from demos
Ignore private functions in mqtt_state.h and .c
* Add CBMC proof for MQTT_GetSubAckStatusCodes function * Fix parameter type in API signature found by CBMC proof
Add utility for MQTT topic filter and topic matching to library (#1119) * Add topic matching utility to MQTT API * Add thorough unit tests for topic matching utility * Fix failing ExactMatch unit test * Add topic matching parameter names to mqtt/lexicon.txt * Fixes caught in code review Co-authored-by: Muneeb Ahmed <[email protected]> * Remove problematic assert in matchWildcardsSpecialCases and make hygiene parameter re-ordering changes * Add another param name to mqtt/lexicon.txt * Update topic matching to support corner case of matching topic filter ending with "/#" with topic name ending with "/" * Remove duplicate word entry in mqtt/lexicon.txt Co-authored-by: Muneeb Ahmed <[email protected]> * Fix bugs in topic matching algorithm that allowed matching when wildcards are not preceding with '/' * Slight style change for improved readability to matchWildcards function * Re-add param names to mqtt/lexicon.txt that were removed in merge conflict resolution * Rename private function for better expressivity * Revert "Rename private function for better expressivity" This reverts commit fe22642. * Hygiene changes for better readability * Add more cases to unit tests * Hygiene changes for invoking matchEndWildcardsSpecialCases function * More hygiene refactors from review comments Co-authored-by: Muneeb Ahmed <[email protected]> * Separate Match and no-match test case sets for # willdcard * Remove extraneous param docstring for private function * Add note to MatchTopic API about assumption and behavior of function Co-authored-by: Muneeb Ahmed <[email protected]>
* Add doxygen code examples for mqtt_lightweight.h * Comment fixes in mqtt.h Co-authored-by: SarenaAWS <[email protected]>
Also, add link to the AWS IoT Device Defender Service in the demo docs. Signed-off-by: Gaurav Aggarwal <[email protected]>
Add migration from V3 to 202011.00 for the Jobs library. Add docs about using the demo and running the demo for the Jobs library. Co-authored-by: SarenaAWS <[email protected]> Co-authored-by: Archit Aggarwal <[email protected]>
Automatically clone submodules of library upon building with cmake instead of failing when the user had not cloned submodules
…1370) Update CMake configuration of openssl_posix target to link against libssl.a when building as a shared library; otherwise, link against libssl.o. This is done to avoid issues when linking static library of OpenSSL when building openssl_posix as a shared library
* Improve README.md mosquitto and httpbin instructions. * Add line-breaks for clearness. * Fix initialize submodules first before the doxygen script.
Adds CRLF check to formatting CI check. Switches all line endings to unix.
* Fix memory leak in tearDown function * Wrong name * Add comment * Do the same for shadow * Wrong parenthesis * Check return status of Openssl_Disconnect
Add git-secrets check to the GHA.
* Feature: CorePKCS * Added corePKCS11 library as a submodule * Added PKCS #11 system tests * Added PKCS #11 demos Update demos/pkcs11/common/include/core_pkcs11_config.h Co-authored-by: SarenaAWS <[email protected]> Update demos/pkcs11/pkcs11_demo_management_and_rng/pkcs11_demo_management_and_rng.c Co-authored-by: SarenaAWS <[email protected]> * Update integration-test/pkcs11/test-config/core_pkcs11_config.h Co-authored-by: Archit Aggarwal <[email protected]> * Update integration-test/pkcs11/test-config/core_pkcs11_config.h Co-authored-by: Archit Aggarwal <[email protected]> * Apply suggestions from code review Co-authored-by: Archit Aggarwal <[email protected]> * Add output to guide user to run the objects demo before the sign and verify demo. * Set result to invalid object handle if unable to find private and public keys. Co-authored-by: Archit Aggarwal <[email protected]>
The existing retry_utils library contains platform dependencies for sleep and rand operations. This PR refactors the library to be platform-agsnotic so that the same library can be used on both POSIX and FreeRTOS platforms.
* Add PKCS #11 library and demos to doxygen. * Add graphviz to CI. * Add plantuml for PKCS demos. * Update docs/doxygen/demos/pkcs11_demo.dox Co-authored-by: SarenaAWS <[email protected]> * Move PKCS #11 submodule forward. * Update plantuml and update PNGs. Co-authored-by: SarenaAWS <[email protected]>
* Update all library submodules to use the latest in main branch.
* Add script to verify items pre-release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )